Skip to content
This repository was archived by the owner on Jan 8, 2024. It is now read-only.

Init Cake5 upgrade #14

Merged
merged 4 commits into from
Sep 21, 2023
Merged

Init Cake5 upgrade #14

merged 4 commits into from
Sep 21, 2023

Conversation

dereuromark
Copy link
Collaborator

@dereuromark dereuromark commented Jan 4, 2023

Prep new semantic major 0.4 release with CakePHP 5

WIP until Cake5 stable is released in a few months

Copy link
Contributor

@dbu dbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, looks like no changes to the code are needed, right?

could we allow installation with both cake 4 and 5 in that case?

@dbu
Copy link
Contributor

dbu commented Jan 5, 2023

did you rename the .php_cs file to .php-cs-fixer.php? if so, the new file is missing in the pull request, which makes the ci fail.

i will remove scrutinizer from the repository configuration.

@dereuromark
Copy link
Collaborator Author

It now uses a native cs approach, maybe you could remove that failing CI call as it is not needed
Now part of CI / Coding Standard & Static Analysis

@dbu
Copy link
Contributor

dbu commented Jan 5, 2023

It now uses a native cs approach, maybe you could remove that failing CI call as it is not needed Now part of CI / Coding Standard & Static Analysis

right. i removed the hooks for travis and styleci.

@dereuromark dereuromark merged commit 6350687 into master Sep 21, 2023
@dereuromark dereuromark deleted the next branch September 21, 2023 10:08
@dereuromark dereuromark restored the next branch September 21, 2023 10:08
@dbu dbu deleted the next branch September 23, 2023 14:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants